fix(v4-sdk): type compatibility in encoding functions for ethers #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
fix type compatibility in encoding functions for ethers
Description
fixed a type issue causing ethers to reject JSBI values.
encodeModifyLiquidities, added.toString()todeadlineto ensure proper encoding.encodeERC721Permit, applied.toString()totokenId,deadline, andnoncefor the same reason.these changes ensure compatibility with ethers when encoding
uint256arguments.How Has This Been Tested?
manually verified that encoding works correctly and ethers no longer throws type errors when handling JSBI values.
Are there any breaking changes?
no breaking changes.
(Optional) Feedback Focus
confirm that this fix aligns with our preferred approach for handling JSBI → string conversions in contract interactions.
(Optional) Follow Ups
consider adding a small utility helper for consistent JSBI-to-string conversions across all encoding functions.