feat: get cached routes to filter out mismatched mixed routes against requested protocol versions #1065
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
… requested protocol versions
…ve the matching protocols
jsy1218
force-pushed
the
siyujiang/route-441-in-get-cached-routes-use-protocolsinvolved-to-filter-out
branch
from
5f82ac7 to
df29b9a
Compare
xrsv
reviewed
Apr 4, 2025
| // requested protocols do not involve MIXED, so there is no need to filter by protocolsInvolved | ||
| !protocols.includes(Protocol.MIXED) || | ||
| // we know MIXED is getting requested, in this case, we need to ensure that protocolsInvolved contains at least one of the requested protocols | ||
| protocols.includes(record.protocolsInvolved.split(',')) |
There was a problem hiding this comment.
protocols.includes(record.protocolsInvolved.split(','))
shouldn't we here make sure that all protocolsInvolved are in protocols
There was a problem hiding this comment.
yep changed to protocols.every((protocol) => (record.protocolsInvolved as String).split(',').includes(protocol)). I also realized that after sending out the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 2 is to filter out the cached routes which happens to be mixed route, and when requested protocol versions include MIXED. We need to ensure, when this happens, mixed route needs to have exact requested protocol versions match, e.g. V2,V3, then MIXED routes has to include V2,V3 in protocolsInvolved.
Pending e2e test