Pass in decay function for input/output #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhwu
reviewed
Oct 17, 2024
codyborn
added a commit
that referenced
this pull request
Oct 18, 2024
* feat, test: round decays in favor of swapper * refactor: move v3 decay functions together * refactor: remove unused function * refactor: unwind isInput from v3LinearDecay * refactor: unwind isInput from decay & tests * style: forge fmt * test: round in favor of swapper when resolving output * refactor: clean curveDelta use * test: split uint16 overflow test into input & output * Pass in decay function for input/output (#312) * Pass in decay function for input/output * forge fmt * Remove MockNonlinearDutchDecayLibContract --------- Co-authored-by: Cody Born <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces code duplication by passing in the appropriate decay function