delete the wrong description for execute and executeBatch in sample-executors /SwapRouter02Executor.sol? #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenta
changed the title
marktoda
previously approved these changes
Feb 9, 2024
|
ah need signed commits |
|
I submitted the new PR because of the signed commit. https://github.com/Uniswap/UniswapX/pull/224/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of the Direct Filler, fillers need to own output tokens in advance. However, they don’t need to have them when they use their strategies in the filler contract. That’s why the description for both functions execute and executeBatch in the SwapRouter02Executor.sol file has been deleted in this pull request.