OZ Audit #212
Merged
OZ Audit #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a couple typos. Fixes: N-03
Gas limit for native transfer can cause some reasonable smart contract wallets that perform operations in their receive function to be unable to receive native output from uniswapX. compatibilty preferred here Resolves M-02
Fixes: N-02
Fixes: L-05
Fixes: L-04
Previously there was ambiguous undefined behavior for if startTime and endTime were the same - This commit removes that ambiguity by enforcing startTime !== endTime
document magic numbers in orderquoter Fixes: L-08
* Remove unused return names * Update OrderQuoter.sol
hensha256
reviewed
Dec 18, 2023
| @@ -28,7 +28,7 @@ library DutchDecayLib { | |||
| view | |||
| returns (uint256 decayedAmount) | |||
| { | |||
| if (decayEndTime < decayStartTime) { | |||
| if (decayEndTime <= decayStartTime) { | |||
There was a problem hiding this comment.
we really wanna revert if theyre the same? is it because they shouldnt be using a decay and should just have a limit order?
There was a problem hiding this comment.
I think it was just undefined behavior what we should do in that case - should we use startAmount or endAmount? with the current impl we used endAmount which is better for the filler and could be unintended by the swapper
There was a problem hiding this comment.
hensha256
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit merges in all OZ audit commits from
developmentintomain. These were previously reviewed#190
#189
#191
#193
#192
#194
#196
#197
#199