Skip to content

UI updates - #159

Open
Smashcat wants to merge 19 commits into
UnifiedEngineering:masterfrom
Smashcat:master
Open

UI updates#159
Smashcat wants to merge 19 commits into
UnifiedEngineering:masterfrom
Smashcat:master

Conversation

@Smashcat

@Smashcat Smashcat commented Feb 20, 2019

Copy link
Copy Markdown

My first time making a pull request on here, so be gentle! I've been posting videos of my updates on Instagram, and users asked me to see if the changes could be added to the main branch.

This branch has a lot of changes to the UI including:

Animated titles, alignment of elements on all screens, important elements now flash
Changes to all bmp files to add continuity
Ability to switch between normal reflow graph and simplified "big number" version while reflowing
Both reflow screens now flash set temp/act temp if they are over 5 degrees apart
Reflow edit screens now use crosshairs, and show m:s and temp at top for each set point.
Splash screen change (Unified Engineering still displayed in About screen)
Settings screen can now scroll if over 6 items. Also has custom text per item when at min/max settings
Screensaver can be set in settings screen, this shows an animated "Pacman" type display while unit idle

I've kept most changes in a few new include files. No changes to reflow/serial functionality.

@deece deece left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of files have seen unnecessary permissions changes. These should be resolved to make life easier for the project maintainers.

Comment thread .cproject
<externalSettings/>
<extensions>
<extension id="org.eclipse.cdt.core.ELF" point="org.eclipse.cdt.core.BinaryParser"/>
<extension id="org.eclipse.cdt.core.GNU_ELF" point="org.eclipse.cdt.core.BinaryParser"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These (and other project changes) are likely not necessary.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks I'll resolve these issues before making another pull request.

Comment thread README.md
==============================
Custom firmware for the cheap T-962 reflow oven utilizing the _existing_ controller hardware.
This project is a fork of the original Unified Engineering firmware for the T-962 reflow oven. This version primarily changes the UI, as I wanted something a little more aesthetic. I added a pre-built .hex file to make it simple to update an oven without needing to install an IDE to build it!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense to contribute back to the parent project.

Comment thread README.md
[Flashing firmware]: https://github.com/UnifiedEngineering/T-962-improvements/wiki/Flashing-the-LPC21xx-controller
[DS18B20]: http://datasheets.maximintegrated.com/en/ds/DS18B20.pdf
[hackaday post]: http://hackaday.com/2014/11/27/improving-the-t-962-reflow-oven/
Quick video of updated UI here: [https://www.youtube.com/watch?v=ooQ-jpgfutc] (Youtube video)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Comment thread src/lcd.c
Y >>= 3;

#ifndef MINIMALISTIC
//#ifndef MINIMALISTIC

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this obsolete? If so, it should be removed rather than commented out.

Comment thread src/lcd.h
#define FB_HEIGHT (64)
#define FB_WIDTH (128)
#define FB_HEIGHT (64)
#define FB_WIDTH (128)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace changes probably shouldn't be pushed back, unless they are part of a cleanup patch.

Comment thread src/nvstorage.h
REFLOW_MIN_FAN_SPEED,
REFLOW_BAKE_SETPOINT_H,
REFLOW_BAKE_SETPOINT_L,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newlines added

Comment thread src/ui_extras.c

LCD_BMPDisplay(stopbmp, 127 - 17, 0);


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace

ImNoahDev added a commit to Lexithean/T-962_ReflowOS that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants