Skip to content

Clean-ups - #415

Open
ocefpaf wants to merge 3 commits into
Unidata:masterfrom
ocefpaf:investigate_windows_arm64_wheel
Open

ocefpaf wants to merge 3 commits into
Unidata:masterfrom
ocefpaf:investigate_windows_arm64_wheel

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

This PR started as an investigation to solve #412 (comment), but I don't believe that windows-11-arm would ever pass on lower Python version. With ABI3 and in the light on the upcoming EoL of Python 3.10 we can clean the setup a little bit:

  • Building Wheels only for Python 3.11 (ABI3) and latest (for testing purposes);
  • Dropped 3.10 from tests b/c it will be EoL next month;
  • Dropped experimental CI, we needed that during the numpy 2.0 migration, now it is just redundant testing;
  • Dropped x32 testing;
  • Moved to a simpler setup without conda.

PS: There is no reason to use conda in the testing here. Different from netcdf4-python, where the netcdf-c, hdf5 from conda helps a lot, we can do an all pip setup for this repository. I'll change the CIs to reflect that here in a tomorrow.

@ocefpaf ocefpaf changed the title test Clean-ups Sep 17, 2026

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as is, you're effectively skipping all free-threaded builds. I would recommend instead to omit CIBW_BUILD entirely so the whole array of supported versions is run.

Comment thread pyproject.toml
@neutrinoceros

Copy link
Copy Markdown
Contributor

I don't believe that windows-11-arm would ever pass on lower Python version

Indeed, no version of numpy has ever supported Python 3.10 on windows arm, so it's no use doing it downstream.

@ocefpaf
ocefpaf force-pushed the investigate_windows_arm64_wheel branch from e5bf007 to b42effd Compare September 18, 2026 13:43
@ocefpaf

ocefpaf commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

as is, you're effectively skipping all free-threaded builds.

I have 0 experience with the free-threaded builds. Should we do them here?

I would recommend instead to omit CIBW_BUILD entirely so the whole array of supported versions is run.

My goal was to do to only oldest (forward compitable with ABO3) and latest (for future proofing) so I kept ``"cp311-* cp315-*"` there. As Python is getting more and more stable I don't see a reason to do them all. I'm fine removing that if you think it is worth to test them all. (We would need to re-do the PR skip from before.)

@ocefpaf
ocefpaf force-pushed the investigate_windows_arm64_wheel branch from b42effd to 5ee9f92 Compare September 18, 2026 13:51
@ocefpaf
ocefpaf marked this pull request as ready for review September 18, 2026 14:03
@ocefpaf

ocefpaf commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@neutrinoceros Let me know what you think. My idea is to reduce the maintenance burden and false positives, like the windows-arm one. I would like to remove more 😬 , like the x32 stuff. However, I think this is enough for now.

@neutrinoceros

Copy link
Copy Markdown
Contributor

Numpy stopped publishing wheels for win x32 a couple months back and as far as I could measure on astropy (using the same method as numpy folks) the downloads are really anecdotal.

Comment thread pyproject.toml Outdated
Comment on lines +42 to +43
CIBW_SKIP: "*-musllinux*"
CIBW_BUILD: "cp311-* cp315-*"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually suggest keeping as much as cibw's configuration as possible in pyproject.toml:

  • a single source of truth is preferable to two
  • static configuration is easier to maintain and reason with

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple comments. I'm only looking at cibw configuration

Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants