Help content update via X@Help from Webpage #22
Open
ZioNeL wants to merge 3 commits intoUndernetIRC:masterfrom
Open
Help content update via X@Help from Webpage #22ZioNeL wants to merge 3 commits intoUndernetIRC:masterfrom
ZioNeL wants to merge 3 commits intoUndernetIRC:masterfrom
Conversation
Fix to allow Help content update for commands via X@Help from Webpage
Fix to allow Help content update for commands via X@Help from Webpage
Fix to allow Help content update for commands via X@Help from Webpage
Ratler
requested changes
Sep 2, 2024
| echo "<input type=hidden name=ts value=$zets>\n"; | ||
| echo "<input type=hidden name=crc value=$zecrc>\n"; | ||
| echo "<input type=hidden name=langid value=$langid>\n"; | ||
| echo "<input type=hidden name=lang_id value=$lang_id>\n"; |
Member
There was a problem hiding this comment.
A much smaller fix would be changing $langid to $lang_id on this line; then no changes are necessary for any other files.
Contributor
Author
There was a problem hiding this comment.
You need to change on all 3 files.
Some task are related with these 3 pages, and some actions (like add, edit) will not work.
Member
There was a problem hiding this comment.
You only need to change all files because you rename name=langid to name=lang_id in the form. If you don't do that, all you would have to do is change:
echo "<input type=hidden name=langid value=$langid>\n";
to
echo "<input type=hidden name=langid value=$lang_id>\n";
But I think the bigger issue is here that we use $langid as input instead of $_POST['langid']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to allow Help content update for commands via X@Help from Webpage