fix(navbar): correct active nav state and standardize glass effect#2536
Open
yachikadev wants to merge 1 commit into
Open
fix(navbar): correct active nav state and standardize glass effect#2536yachikadev wants to merge 1 commit into
yachikadev wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2207 — Navbar active state and visual consistency issues
Problem
highlighted even after navigating to Resume or Leaderboard.
page, only switching to the blurred/glass effect after scrolling, while
Resume and Leaderboard showed the glass effect from the start.
Root cause
isActivePath()matched/dashboardusingpathname.startsWith(), whichalso matched
/dashboard/career-intelligence, keeping "Overview" active onevery dashboard sub-route.
the blue-background flash — it appears to have been tied to the same
startsWith-based logic / stale build artifacts rather than a separate
conditional background. Standardized the navbar style application to be
fully route-agnostic going forward.
Fix
/dashboardinisActivePath()soeach dashboard route only highlights its own nav item.
scrolled-based background/blur logic inAppNavbar.tsxis applied identically regardless of route, removing anyroute-dependent styling divergence.
Testing
/dashboard,/dashboard/career-intelligence, and/leaderboard.on all three routes from initial load.
Note for reviewers
Unrelated observation:
TokenRevokedBannerandAppNavbarboth useposition: fixed/sticky,top: 0,z-50, which could cause overlap when thetoken-revoked banner shows. Not fixed here — flagging for a separate issue if
needed.