Skip to content

Fix TopRepos error handling and improve UI statesFix toprepos#125

Closed
nangaretejal991-bit wants to merge 6 commits into
Umbrella-io:mainfrom
nangaretejal991-bit:fix-toprepos
Closed

Fix TopRepos error handling and improve UI statesFix toprepos#125
nangaretejal991-bit wants to merge 6 commits into
Umbrella-io:mainfrom
nangaretejal991-bit:fix-toprepos

Conversation

@nangaretejal991-bit

Copy link
Copy Markdown
  • Added proper error state with retry button
  • Fixed empty state logic
  • Improved API handling

@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

@nangaretejal991-bit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has two separate issues blocking it:

1. Mixed commits from two different contributors
The commit history shows work from both MansimranKaurBedi0 (copy URL feature on DashboardHeader) and nangaretejal991-bit (TopRepos improvements). These are unrelated changes and should be submitted as separate PRs — one per feature, one author each.

2. Broken diffs in both files

DashboardHeader.tsx: Has duplicate useState import and leftover dead code from the original file after the new function closes. The file as patched would not compile.

TopRepos.tsx: Contains two conflicting .then() chains — both the old and new implementations are present in the file, causing a syntax error.

Please:

  1. Rebase on main
  2. Submit the DashboardHeader copy button as its own clean PR
  3. Submit the TopRepos improvements as a separate clean PR

Also: package-lock.json removes "peer": true on 12 entries — this is npm version noise unrelated to the feature. After rebasing, run git checkout origin/main -- package-lock.json before committing.

@Priyanshu-byte-coder

Copy link
Copy Markdown
Member

Closing per the review feedback — this PR mixes commits from two contributors and has broken diffs in both DashboardHeader.tsx and TopRepos.tsx. Please submit as two separate clean PRs: one for the TopRepos improvements and one for the DashboardHeader copy-URL button (note: a clean PR for the copy-URL feature already exists as #66).

@Priyanshu-byte-coder Priyanshu-byte-coder added the gssoc:approved GSSoC: PR approved for scoring label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants