Fix TopRepos error handling and improve UI statesFix toprepos#125
Fix TopRepos error handling and improve UI statesFix toprepos#125nangaretejal991-bit wants to merge 6 commits into
Conversation
nangaretejal991-bit
commented
May 15, 2026
- Added proper error state with retry button
- Fixed empty state logic
- Improved API handling
|
@nangaretejal991-bit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
This PR has two separate issues blocking it:
1. Mixed commits from two different contributors
The commit history shows work from both MansimranKaurBedi0 (copy URL feature on DashboardHeader) and nangaretejal991-bit (TopRepos improvements). These are unrelated changes and should be submitted as separate PRs — one per feature, one author each.
2. Broken diffs in both files
DashboardHeader.tsx: Has duplicate useState import and leftover dead code from the original file after the new function closes. The file as patched would not compile.
TopRepos.tsx: Contains two conflicting .then() chains — both the old and new implementations are present in the file, causing a syntax error.
Please:
- Rebase on
main - Submit the DashboardHeader copy button as its own clean PR
- Submit the TopRepos improvements as a separate clean PR
Also: package-lock.json removes "peer": true on 12 entries — this is npm version noise unrelated to the feature. After rebasing, run git checkout origin/main -- package-lock.json before committing.
|
Closing per the review feedback — this PR mixes commits from two contributors and has broken diffs in both DashboardHeader.tsx and TopRepos.tsx. Please submit as two separate clean PRs: one for the TopRepos improvements and one for the DashboardHeader copy-URL button (note: a clean PR for the copy-URL feature already exists as #66). |