GH#2741: Cover nested confirmation isolation

[superdav42]

Summary

Added a second nested browser ability call to confirm confirmation state remains scoped to the approved target.

Files Changed

tests/SdAiAgent/Core/AgentLoopTest.php

Runtime Testing

• Risk level: Medium
• Verification: self-assessed — PHP syntax check, JavaScript/CSS lint, production build, and bundle budget check passed. Full PHPUnit, PHPCS, and PHPStan could not run because this worktree lacks Composer vendor binaries.

Resolves #2741

---

aidevops.sh v3.32.317 plugin for OpenCode v1.18.31 with gpt-5.6-terra spent 5m and 69,844 tokens on this as a headless worker.

Summary by CodeRabbit

• Tests
  • Expanded coverage for resuming nested browser calls after confirmation.
  • Verifies that confirmation status applies only to the approved call, while unapproved calls remain unconfirmed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f3e13df8-ac10-476c-8028-9008a4c0630c

📥 Commits

Reviewing files that changed from the base of the PR and between 0abd4cf and 65d3197.

📒 Files selected for processing (1)

• tests/SdAiAgent/Core/AgentLoopTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The confirmation-resume test now covers two nested browser calls. It verifies that user_confirmed remains limited to the approved call.

Changes

Confirmation isolation

Layer / File(s)	Summary
Nested call confirmation assertions tests/SdAiAgent/Core/AgentLoopTest.php	The test adds an unapproved nested insert-block call and its client descriptor. Assertions verify that the unapproved call lacks user_confirmed, while the approved Elementor call retains it.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 65d31

The test correctly verifies confirmation isolation for nested browser calls. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding test coverage for nested confirmation isolation. It references the linked issue and uses specific terminology from the changeset.
Linked Issues check	✅ Passed	Issue #2741 requires a regression test for nested confirmation isolation. The reviewed change expands test_confirmation_resume_marks_nested_client_call_as_confirmed in `tests/SdAiAgent/Core/AgentLoo…
Out of Scope Changes check	✅ Passed	The reviewed change is limited to tests/SdAiAgent/Core/AgentLoopTest.php and adds focused regression coverage for issue #2741. The change does not introduce unrelated production behavior or unrelate…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[superdav42]

Completion Summary

• What: Added a second nested browser ability call to confirm confirmation state remains scoped to the approved target.
• Issue: Review followup: PR #2736 — GH#2735: Preserve confirmation for nested browser abilities #2741
• Files changed: tests/SdAiAgent/Core/AgentLoopTest.php
• Testing: PHP syntax check, JavaScript/CSS lint, production build, and bundle budget check passed. Full PHPUnit, PHPCS, and PHPStan could not run because this worktree lacks Composer vendor binaries.
• Key decisions: none

---

aidevops.sh v3.32.317 plugin for OpenCode v1.18.31 with gpt-5.6-terra spent 5m and 69,844 tokens on this as a headless worker.

---

Merged via PR #2742 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

Routing feedback

• Route: standard; 1 attempt, 21 LLM requests, 0 capability escalations, 0 same-tier fallbacks.
• Population: headless; 0 objective outcomes.
• Usage: 998,700 tokens; $0.4258 estimated cost.
• Recommendation: No routing change is recommended from this sample.