Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing
reference_material_id
#322Add missing
reference_material_id
#322Changes from all commits
7c98045
8b0bc32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need a reference_material_id for generic brand materials. We only support Ultimaker brand materials for method and sketch. The Generic materials are all excluded in teh machine definitions of these machines.
For other machines the material_reference_id has no meaning at all. Best not to put materials reference ids for the generic materials in the all_materials.csv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just syncing them with how they're currently used in Cura, DF, Lauren based on the uuid.
When I'm back on Wednesday I will create aan Look up table for the Mirage on look-up-tables that we have.
Let's leave these PR's open for now. We don't have a rush to get these in before Wednesday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only removed ASA and Nylon-CF for now, because there are already Ultimaker materials linked to them. The PC. BVOH, CPE, TPU and HIPS have no Ultimaker material mapped to them, so we can use the Generic materials.