Skip to content

bugfix ecs_is_tag to work with pairs #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardlyardi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix ecs_is_tag to work with pairs #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b1c94
fix
hardlyardi Jan 4, 2026
9c96e10
meow
Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rokit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tools]
wally = "upliftgames/[email protected]"
rojo = "rojo-rbx/[email protected]"
luau = "luau-lang/[email protected]"
[tools]
wally = "upliftgames/[email protected]"
rojo = "rojo-rbx/[email protected]"
luau = "luau-lang/[email protected]"
zune = "scythe-technology/[email protected]"
18 changes: 15 additions & 3 deletions src/jecs.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3864,12 +3864,24 @@ local function world_new(DEBUG: boolean?)
return world
end

local function ecs_is_tag(world: world, entity: i53): boolean
local idr = world.component_index[entity]
local function ecs_is_tag(world: world, id: i53): boolean
local idr = world.component_index[id]
if idr then
return bit32.btest(idr.flags, ECS_ID_IS_TAG)
end
return not WORLD_HAS(world, entity, EcsComponent)
if ECS_IS_PAIR(id) then
local relation = entity_index_get_alive(entity_index, ECS_PAIR_FIRST(id)) :: i53
if not relation then
return false
end
if WORLD_HAS(world, relation, EcsComponent) then
return false
end
local target = entity_index_get_alive(entity_index, ECS_PAIR_SECOND(id)) :: i53
if not target then return false end
return not WORLD_HAS(world, target, EcsComponent)
end
return not WORLD_HAS(world, id, EcsComponent)
end

local function ecs_entity_record(world: world, entity: i53)
Expand Down