Refactored ConsoleLogger to fix emoji handling and ensure consistency… #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristipufu |
Karanraj-6
force-pushed
the
emojis-with-unicode-425
branch
from
be5ad76 to
48c243d
Compare
radu-mocanu
reviewed
Sep 30, 2025
src/uipath/_cli/_utils/_console.py
Outdated
| SELECT = "👇" | ||
| LINK = "🔗" | ||
| MAGIC = "✨" | ||
| INFO = "\u2139" # ℹ️ (INFORMATION SOURCE) |
There was a problem hiding this comment.
Suggested change
| INFO = "\u2139" # ℹ️ (INFORMATION SOURCE) | |
| INFO = "" # (INFORMATION SOURCE) |
- Updated all ConsoleLogger convenience methods to pass Enum members instead of .value - Fixed log() to extract emoji with level.value internally, maintaining type-safety - Ensured error messages use level == LogLevel.ERROR for stderr - Made evaluation progress methods consistent with LogLevel Unicode symbols - Overall: logging and progress updates now reliably display intended Unicode symbols -> recent change: updated "info" unicode to empty string.
Karanraj-6
force-pushed
the
emojis-with-unicode-425
branch
from
48c243d to
e4b1582
Compare
radu-mocanu
reviewed
Oct 10, 2025
Comment on lines
+92
to
+93
| if fg: | ||
| formatted_message = f"{emoji} {click.style(message, fg=fg)}" if emoji else click.style(message, fg=fg) |
There was a problem hiding this comment.
we can simplify the logic here:
Suggested change
| if fg: | |
| formatted_message = f"{emoji} {click.style(message, fg=fg)}" if emoji else click.style(message, fg=fg) | |
| formatted_message = f"{level.value} " if level.value else "" | |
| formatted_message += click.style(message, fg=fg) if fg else message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with LogLevel Enum: