node: fix failing tests #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- configure Node to ignore `UnhandledPromiseRejection` - this used to be default behaviour in Node 14 and was changed to throw in Node 15 (the pipeline doesn't request a specific version of Node which means at the time of writing it's using Node 20) see this anchor: https://nodejs.org/api/cli.html#--unhandled-rejectionsmode - `npm test` calls `mocha` which is able to pass through the setting to `node(.exe)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick in reverse from the "Fix/namedpipe close" PR; more specifically, it intends to apply this commit's delta to
master.