Skip to content

fix(apollo-react): keep the Wind chat loading skeleton in the message column - #1571

Merged
BenGSchulz merged 1 commit into
mainfrom
claude/chat-skeleton-styling-82928f
Nov 12, 2026
Merged

BenGSchulz merged 1 commit into
mainfrom
claude/chat-skeleton-styling-82928f

Conversation

@BenGSchulz

@BenGSchulz BenGSchulz commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Why

When a conversation is opened from history in a full-screen Wind chat (for example the
Conversational Agents page in uipath-ui-widgets), the loading skeleton spans the whole panel
instead of the centered column the transcript and composer use.

The full-screen layout gives MessageList a contentClassName with the column's max width, but
only the transcript used it. The skeleton that replaces the transcript while loading ignored it.

What

  • The skeleton takes the list's contentClassName, so it gets the same centered max width.
  • Its padding is now the transcript's (px-6 pt-3 pb-4 instead of p-4), so it lines up with
    the messages that replace it.
  • The embedded layout passes no column classes, so only its padding changes slightly.

Demo

Wind playground, FullScreen, light theme, with the loading state held open.

compare

Testing

  • New unit test: the skeleton gets the full-screen column classes. It fails without the fix.
  • The 19 message-list tests and biome check pass.
  • Storybook: compared the skeleton with the composer column before and after (screenshots above).

🤖 Generated with Claude Code

… column

The initial skeleton ignored the list's contentClassName, so in full
screen it spanned the whole panel instead of the centered column the
transcript uses. It now takes the column classes and the transcript's
padding, so it lines up with the messages that replace it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 12, 2026 19:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions
github-actions Bot temporarily deployed to preview/apollo-design November 12, 2026 19:49 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex November 12, 2026 19:49 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs November 12, 2026 19:49 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing November 12, 2026 19:49 Destroyed
@github-actions github-actions Bot added the size:S 10-29 changed lines. label Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1958 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1722
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

⚠️ Visual changes detected: 3 changed (of 8 compared, 5 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Nov 12, 2026, 11:58:32 AM

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.02 MB 50.17 MB ±0
@uipath/apollo-react 59.7% — (4 untracked) 2.49 MB 14.02 MB +22 B
@uipath/apollo-ui-icons — — 2.86 MB 6.97 MB ±0
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind — — 897.6 KB 5.07 MB +2 B
@uipath/ap-chat 85.8% — 40.48 MB 46.10 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@BenGSchulz
BenGSchulz merged commit 6b45331 into main Nov 12, 2026
38 checks passed
@BenGSchulz
BenGSchulz deleted the claude/chat-skeleton-styling-82928f branch November 12, 2026 22:07

This branch was successfully deployed

No deployments
preview/apollo-landing — 43b29dc5 Deployed Nov 12, 2026 by github-actions[bot]
preview/apollo-vertex — 43b29dc5 Deployed Nov 12, 2026 by github-actions[bot]
preview/apollo-docs — 43b29dc5 Deployed Nov 12, 2026 by github-actions[bot]
preview/apollo-design — 43b29dc5 Deployed Nov 12, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:S 10-29 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants