Skip to content

chore(storybook): exclude the canvas performance story from sbdiff - #1563

Merged
david-rios-uipath merged 1 commit into
mainfrom
chore/sbdiff-exclude-canvas-performance
Nov 10, 2026
Merged

david-rios-uipath merged 1 commit into
mainfrom
chore/sbdiff-exclude-canvas-performance

Conversation

@david-rios-uipath

Copy link
Copy Markdown
Contributor

Why

apollo-react-canvas-templates-canvas-performance--performance is a stress test. It blocks the main thread for about 7 s on load and fails sbdiff's capture deadline on every visual-diff run, so it only adds errors and time.

What

Adds .sbdiff.json at the repo root with an exclude entry for that story.

Not effective yet

exclude is added by UiPath/storybook-diff#120, which is not released. On the current SBDIFF_VERSION (1.13.4) unknown config keys are ignored, so this file is a no-op until SBDIFF_VERSION in .github/workflows/preview-deploy.yml is bumped to a release that includes it. Draft until then; the bump can be added to this PR.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 22:21
@github-actions
github-actions Bot temporarily deployed to preview/apollo-vertex November 10, 2026 22:21 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-docs November 10, 2026 22:21 Destroyed
@github-actions
github-actions Bot temporarily deployed to preview/apollo-design November 10, 2026 22:21 Destroyed
@github-actions github-actions Bot added the size:XS 0-9 changed lines. label Nov 10, 2026
@github-actions
github-actions Bot temporarily deployed to preview/apollo-landing November 10, 2026 22:22 Destroyed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the performance-story exclusion configuration, which takes effect only after sbdiff is upgraded to support exclusions.

No open issues 🎉

What changed in this PR

Adds configuration to exclude the canvas performance stress-test story from visual diffs, avoiding its recurring capture timeouts once exclusion support is available.

Changes:

  • Adds the performance story ID to sbdiff’s exclusion list.
  • As documented, this remains a no-op on sbdiff 1.13.4 until the workflow version is upgraded to a release supporting exclude.
File Description
.sbdiff.json Configures exclusion of the canvas performance stress-test story.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1958 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1722
ISC 91
Apache-2.0 57
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
CC0-1.0 4
MIT-0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — — — —
@uipath/apollo-react — — — — —
@uipath/apollo-ui-icons — — — — —
@uipath/apollo-vertex — — — — —
@uipath/apollo-wind — — — — —
@uipath/ap-chat — — — — —

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@david-rios-uipath
david-rios-uipath marked this pull request as ready for review November 10, 2026 22:26
@david-rios-uipath
david-rios-uipath merged commit c335e2f into main Nov 10, 2026
39 of 40 checks passed
@david-rios-uipath
david-rios-uipath deleted the chore/sbdiff-exclude-canvas-performance branch November 10, 2026 22:27

This branch was successfully deployed

No deployments
preview/apollo-landing — c44e72bc Deployed Nov 10, 2026 by github-actions[bot]
preview/apollo-design — c44e72bc Deployed Nov 10, 2026 by github-actions[bot]
preview/apollo-docs — c44e72bc Deployed Nov 10, 2026 by github-actions[bot]
preview/apollo-vertex — c44e72bc Deployed Nov 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants