Skip to content

Conversation

@animeshroydev
Copy link

Alert Dialog added if there is no internet connection in the QUIZ App.

Initially if the internet connection is off in the quiz app there is no Alert Dialog pops up. For attempting quiz, internet connection is needed but in the quiz app there are already some quizes that loads up previously(when the internet was connected) but if the user not connected then there was no alert dialog pops up. I have included this features so that the user know about it that he/she need to connect with data/wifi.

Screenshots

BEFORE:
screenshot_20180516-220028

AFTER:
screenshot_20180516-220121

I know it's just a simple feature but it will make a good user expreience. So please leave your feedback on it... @drulabs @CoderVishalSehgal @aditisoni8899

Copy link
Collaborator

@drulabs drulabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animeshroydev it is a good user experience to show an alert dialog that directly takes the user to network or wifi settings. Thanks for the suggestion. Here are a few things that need attention:

  • There is a utils/Connectivity class, the isConnected method in HomeActivity can be moved there with a different name like isDataOrWifiConnected
  • The negative and positive button on alert dialog should be swapped I think.
  • Where ever possible convert single method anonymous interfaces instances into lambdas.
  • Also please remove hard-coded strings.

The rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants