Skip to content
This repository was archived by the owner on Feb 5, 2024. It is now read-only.

Conversation

@enjineerMan
Copy link
Collaborator

@enjineerMan enjineerMan commented Jun 22, 2022

Description

Put PID in own thread separate from SF.
https://app.asana.com/0/187002107997407/1202310505198858/f

Testing

Code should behave as before but faster.

Merge Checklist:

  • The changes have been well commented, particularly in hard-to-understand areas.
  • The code has been tested on hardware, either by me or someone else.
  • Comprehensive unit tests have been made for this change
  • Corresponding changes to documentation have been created and links to this documentation are provided within the pull request.
  • The changes generate no new warnings and compile and run; A screenshot of a successful compile message is attached to the bottom of this PR.

image

@enjineerMan enjineerMan changed the base branch from devel to Controls June 22, 2022 00:23
@antholuo
Copy link
Member

Looks 90% good to me.

Not sure on the specifics, but please double check that TeleopInstructions aren't being voided or null'd as the program runs, and double check that the only driver for PID Output is your thread.

If you can, test in person. If you can't, let's pair you up with someone and get it tested before we merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants