Bug fix for parameter i/o and checks#136
Open
KMarkert wants to merge 8 commits intoUW-Hydro:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a few bugs that were occurring with parsing/checking routing information or writing data out. Specific changes:
rvic/parameters.py: updated pour point parsing to use pandas v1+ APIsetup.py: added pandas v1+ as dependencyrvic/core/utilities.py: fixed bug trying to access .max() method on scalar floatsrvic/core/utilities.py: squeezed output char_names when writing to fileTests were run on the samples/configs/rvic.parameters.rasm.cfg using
rvic parameterand samples/configs/rvic.convolution.rasm.cfg usingrvic convolution.