-
Notifications
You must be signed in to change notification settings - Fork 1
Class data isolation #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Class data isolation #436
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
061e432
class data isolation
nevins321 eb4c01e
Merge branch 'stage' into class-data-isolation
nevins321 7f4a21e
Merge branch 'dropdown-menu-implementation' into class-data-isolation
nevins321 d3e5d50
fixed from dropdown pr
nevins321 21519a7
Merge branch 'dropdown-menu-implementation' into class-data-isolation
nevins321 c55baad
Merge branch 'dropdown-menu-implementation' into class-data-isolation
nevins321 b4ffcfe
Merge branch 'dropdown-menu-implementation' into class-data-isolation
nevins321 5a43b4f
Merge branch 'stage' into class-data-isolation
nevins321 e3d6754
bug fix
nevins321 8761bc0
fixed
nevins321 f3db324
almost
nevins321 8499322
fixed now!
nevins321 30f66a8
Merge branch 'stage' into class-data-isolation
nevins321 9fabe78
new user fix
nevins321 fee6b9b
aidan fix
nevins321 2eb92f4
raw user facing error, removed and fixed
nevins321 94e8b93
aidan fix pt 2
nevins321 14f0af4
done
nevins321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export const useSelectedClass = () => { | ||
| const route = useRoute() | ||
| const storedClassId = useCookie<string | null>('selected-class-token', { | ||
| sameSite: 'lax', | ||
| }) | ||
|
|
||
| const classId = computed(() => { | ||
| const queryClassId = route.query.class | ||
| const normalizedQueryClassId = Array.isArray(queryClassId) ? queryClassId[0] : queryClassId | ||
|
|
||
| return normalizedQueryClassId || storedClassId.value || null | ||
| }) | ||
|
|
||
| return { | ||
| classId, | ||
| storedClassId, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.