Separate RMP and syllabus summaries - #635
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AbhiramTadepalli
left a comment
AbhiramTadepalli
left a comment
There was a problem hiding this comment.
Looks really good! Do you think we can add a divider, header, or some spacing between the rmp and syllabus cards? It sort of feels like the weighting and grade scale go with RMP.
Also in light mode, can you darken the weighting and grade scale cards? Or give it a light cornflower bg color
|
Thank you for the good ideas and points, I went with 
|
NishilJ
left a comment
NishilJ
left a comment
There was a problem hiding this comment.
Nice job, looks good, but was wondering if it would make sense to extract a component for the weighting and grade tables and their loading variants. Could reduce a decent amount of duplicated code.
|
Good catch, didn't even think of how much code duplication I was doing. |
3 participants
Separated the the RMP and syllabus summary features in card dropdowns so now you can see the syllabus summary when the professor does not have any RMP. I also updated the style to use dense MUI tables so it's more recognizable as multiple tables.
In the process, I needed the BaseCard component added to all the projects in the #558 set of issues and realized it should have been added in #613. I missed that in the review so added it here. This matches card colors, rounded corners, and shadows with the rest of the Nebula projects. For the most part the cards just look a tad lighter, easy to see the difference by tabbing between https://dev.trends.utdnebula.com/dashboard?searchTerms=John+Cole&availability=26F and https://utd-trends-git-607-separate-rmp-and-syllabus-utdnebula.vercel.app/dashboard?searchTerms=John+Cole&availability=26F.
Before:
After:
(expanded)