Skip to content

Add footer - #120

Merged
TyHil merged 15 commits into
developfrom
footer
Jun 6, 2026
Merged

Add footer#120
TyHil merged 15 commits into
developfrom
footer

Conversation

@mikehquan19

@mikehquan19 mikehquan19 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Overview

Fixes #83

Add footer that links to other sources.

One thing i wanted to do is maybe adding a line "Sources you can reference to verify or reserve rooms", but I'm not sure how to best place it given the current layout, or if I should place it at all.

@vercel

vercel Bot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
utd-rooms Ready Ready Preview, Comment Jun 6, 2026 7:58pm

Request Review

@mikehquan19
mikehquan19 marked this pull request as draft May 4, 2026 05:52
@mikehquan19
mikehquan19 marked this pull request as ready for review May 4, 2026 06:35
@mikehquan19

mikehquan19 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

@TyHil, i really hope you remember the random ai you used to add coloring and gradient on our logo and background stuff, cuz gemini is ragebating me here.

Screenshot 2026-05-04 at 01 34 41 Screenshot 2026-05-04 at 01 34 48 Screenshot 2026-05-04 at 01 34 59 Screenshot 2026-05-04 at 01 35 03

@mikehquan19

mikehquan19 commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

I'm going to try something else on the color cuz it looks kinda .... too dark, the footer below, any suggestions?

Screenshot 2026-05-04 at 01 37 57

@TyHil

TyHil commented May 4, 2026

Copy link
Copy Markdown
Member

Hahahaha crazy rage bait

How about using bg-royal on light mode and bg-cornflower-300 on dark mode, instead of the image

@mikehquan19

mikehquan19 commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure if "back to top" should be a button, or like a link. I can definitely make it like our website but given current layout, I just put it in the middle for now (rather than to the right like our website).

We don't have discord link yet so I'll work on that. Also if you hover to the back to top, it will be very funny now so don't mind it.

Screenshot 2026-05-04 at 23 42 55

@TyHil

TyHil commented May 5, 2026

Copy link
Copy Markdown
Member

Nice! Just from the screenshot I might suggest this capitalization:

  • "For organizations" --> "For Organizations"
  • "For students" --> "For Students"
  • "Comet Calendar"
  • "Building Hours"
  • "Our website" --> "Website"

@TyHil TyHil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good so far!

Make sure all the text and images in the footer swap to white in light mode! You'll want to use Tailwind for this by having both images next to each other one with smth like className="block dark:hidden" and the other with className="hidden dark:block"

Comment thread src/components/Footer.tsx
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread public/footer-logo.svg Outdated
@mikehquan19

Copy link
Copy Markdown
Contributor Author

@TyHil I addressed most of the comments. Let me know how you like it, especially the Logo because I just used UTDRoomsLogoCombination (thanks @Isoscelestial that it's customizable enough) but I couldn't quite get the project logo down a little bit.

I also added the privacy policy (the general one from website v2 but if we don't need it here, I can remove it in a snap)

Also I removed 2 excluded rooms, they won't affect the app I'm sure cuz backend took care of it.

@mikehquan19
mikehquan19 requested a review from TyHil June 6, 2026 04:30
@mikehquan19

mikehquan19 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-05 at 23 31 54

One thing that doesn't sit well with my eyes is the contact column is too long, I have an idea of bringing the discord button next to the top button but that will surely look bad on mobile view.

@TyHil TyHil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple small things

Comment thread public/legal/privacy-policy.txt Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
Comment thread src/components/Footer.tsx Outdated
@mikehquan19

Copy link
Copy Markdown
Contributor Author

Do we have a way of switching to light mode I can check out the effect? Like changing tailwind config

@TyHil

TyHil commented Jun 6, 2026

Copy link
Copy Markdown
Member

Yeah, in Firefox it's this button:
image

In Chrome go to:
image
then find:
image

@mikehquan19

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-06 at 14 50 51

@mikehquan19
mikehquan19 requested a review from TyHil June 6, 2026 19:53
Comment thread src/components/Footer.tsx Outdated
@TyHil
TyHil merged commit 9c09397 into develop Jun 6, 2026
3 checks passed
@TyHil
TyHil deleted the footer branch June 6, 2026 20:19
@AbhiramTadepalli

Copy link
Copy Markdown

Really quick, are we okay with using the "maintainer" terminology in the footer?

@TyHil

TyHil commented Jun 7, 2026

Copy link
Copy Markdown
Member

It's a bit older for us but I think still makes sense. I could remove/change it if you want tho. I realized the footer isn't in loading.tsx so I was gonna make a change anyways

@AbhiramTadepalli

AbhiramTadepalli commented Jun 7, 2026

Copy link
Copy Markdown

@NishilJ would you like it to say "Nebula Labs Portfolio Team"? Or we could eventually add a "Nebula Labs Maintainers" footer to all our projects

@TyHil

TyHil commented Jun 7, 2026

Copy link
Copy Markdown
Member

I'd push back a bit on it being anything team name specific, something for the whole org would be good. It only said maintainers cause that's what our engineering division kinda used to be called, so that's what the main website says

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Link to other sources

3 participants