-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New config API with TOML #9
Conversation
7f3f527
to
c934655
Compare
@iBug Request for an early review before the documentation is finished. We'd like to take advantage of the expressivity of TOML to unblock more and more flexible configurations. |
Looks great so far. Nothing to complain about. Keep up with your good work! |
I have to apologize that this PR goes far beyond simply adding an alternative config API, but it's not an easy task to split all the updates off now. I would try some time tomorrow if I have time. If it didn't work, we'll have to squash all those stuffs in a single commit. |
I believe the commit history is now clean enough for a fast-forward merge. |
3aafe04
to
eb038a6
Compare
This PR adds a new config API base on TOML, aiming for replacing the existing JSON one. The new config API has adopted the following changes:
logger
has gained a switch and now requires an endpoint URL, preparing for the upcoming OpenTelemetry support;host-keys
can be hard-coded alternatively in base64 or string format;Tests are updated to reflect these changes. They now uses static fixtures, eliminating the requirement of a
/tmp/sshmux
directory andssh-keygen
tool. The JSON APIs are deprecated but not removed, so tests are now performed against both formats.This PR also adds
SO_REUSEPORT
support to sshmux, unblocking #1.