BBA-21 Add support for toolbar button selection #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow users to position the global buttons to the left or right of the app specific buttons - Add unit test for toolbar to ensure the positioning works - Setting default for global buttons to appear to the right of app buttons (this way they do not move depending upon page buttons)
martin-the-geek
requested changes
Jun 22, 2017
| @@ -0,0 +1,87 @@ | |||
| import { | |||
There was a problem hiding this comment.
can we get the tabbing set to 4 spaces
| <ng-template [cfToolbarHost]="portal | async"> | ||
| </ng-template> | ||
| </span> | ||
| <ng-container [ngSwitch]="globalButtonAlign | async"> |
There was a problem hiding this comment.
instead of changing the order in the document, we can use flexbox to either reverse the order or explicitly set the flexbox order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or right of the app specific buttons
of app buttons (this way they do not move depending upon page buttons)