Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Requirements Propertie #278

Merged

Conversation

DragonSlayer62
Copy link
Contributor

Added AOS Lower Requirement propertie.

@DragonSlayer62
Copy link
Contributor Author

After testing this again by itself, seems to be working from the standpoint of AOS. from aos launch

Copy link
Collaborator

@Xoduz Xoduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UOGuide mentions that the "Lower Requirement" property also lowers the actual weight of the item:

It lowers the overall weight of an item by the percentage given.

Might want to work that into CBaseObject::GetWeight(), so the weight returned is reduced by the percentage given in the lower requirement property. That will reduce the effective weight of the weapon, but won't touch the original weight of it.

ALSO, I don't see anywhere reading in the LOWERTATREQ tag from DFNs, only for reading it in from worldfiles.

Lastly, something to consider: It's not just Strength that can be a requirement for equipping items in UOX3. Intelligence and Dexterity properties on items will also determine whether they can be equipped by a player. Should we not support these as well, when we're adding a new property that can lower the requirement of one particular stat (Strength)?

@Xoduz Xoduz added Changes Requested Change requested as part of Review enhancement New feature or request labels Jan 24, 2025
@DragonSlayer62
Copy link
Contributor Author

DragonSlayer62 commented Jan 25, 2025

Per osi it only allows STR i was going off old uo.stratics page from way back machine. for aos
Lower Requirements - Lowers the strength, dexterity, and intelligence requirements to wear an object. so yeah dex and int but was changed later to only str
https://web.archive.org/web/20030412180545/http://uo.stratics.com/content/aos/itemeffects.shtml

This been updated to s uppport int and dex

@Xoduz Xoduz self-requested a review January 25, 2025 18:02
@Xoduz Xoduz added Ready to Be Merged and removed Changes Requested Change requested as part of Review labels Jan 25, 2025
@Xoduz Xoduz merged commit 0d9bb22 into UOX3DevTeam:develop Jan 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready to Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants