AOS Properties Regeneration #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed cast and added it to npcs.cpp so it can be used on them as well.
Regen function/property names updated to be more in line with existing naming conventions Fixed an issue where health regen setting would be loaded for both health, stamina and mana when parsing uox.ini
Moved regenstats to baseonject because it can be used on both npc and item. removed it out of citems.cpp
strattond
requested changes
Jan 14, 2025
| @@ -6565,6 +6616,15 @@ auto CServerData::HandleLine( const std::string& tag, const std::string& value ) | |||
| case 349: // LOOTDECAYSWITHNPCCORPSE | |||
| NpcCorpseLootDecay( static_cast<UI16>( std::stoul( value, nullptr, 0 )) != 0 ); | |||
| break; | |||
| case 350: // HEALTHREGENCAP | |||
| HealthRegenCap( std::stof( value )); | |||
There was a problem hiding this comment.
stof returns a floating point value - but the caps take a SI16.
I'd expect this to be different e.g. stoi
| @@ -6565,6 +6616,15 @@ auto CServerData::HandleLine( const std::string& tag, const std::string& value ) | |||
| case 349: // LOOTDECAYSWITHNPCCORPSE | |||
| NpcCorpseLootDecay( static_cast<UI16>( std::stoul( value, nullptr, 0 )) != 0 ); | |||
| break; | |||
| case 350: // HEALTHREGENCAP | |||
| HealthRegenCap( std::stof( value )); | |||
There was a problem hiding this comment.
Suggested change
| HealthRegenCap( std::stof( value )); | |
| HealthRegenCap( std::stoi( value )); |
There was a problem hiding this comment.
xuri has pulled this so not sure what updates he made or changes ill wait to see
| HealthRegenCap( std::stof( value )); | ||
| break; | ||
| case 351: // STAMINAREGENCAP | ||
| StaminaRegenCap( std::stof( value )); |
There was a problem hiding this comment.
Suggested change
| StaminaRegenCap( std::stof( value )); | |
| StaminaRegenCap( std::stoi( value )); |
| StaminaRegenCap( std::stof( value )); | ||
| break; | ||
| case 352: // MANAREGENCAP | ||
| ManaRegenCap( std::stof( value )); |
There was a problem hiding this comment.
Suggested change
| ManaRegenCap( std::stof( value )); | |
| ManaRegenCap( std::stoi( value )); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regeneration Hit Points
Regeneration Stam Points
Regeneration Mana Points
Added AOS formula for mana regeneration. Only Active in AOS and up.