Open
Conversation
Dormarble
reviewed
Apr 18, 2021
src/utils/api.js
Outdated
| export const API_FIND_ID = makeAPI(GET, '/user/id'); | ||
| export const API_FIND_PW = makeAPI(GET, '/user/password'); | ||
| export const API_SEND_CODE = makeAPI(POST, 'user/auth'); | ||
| export const API_AUTH_EMAIL = (userID, code) => makeAPI(POST, `user/auth/${userID}/${code}`); |
Member
There was a problem hiding this comment.
함수로 만든 건 의도하신 건가요??
Suggested change
| export const API_AUTH_EMAIL = (userID, code) => makeAPI(POST, `user/auth/${userID}/${code}`); | |
| export const API_AUTH_EMAIL = makeAPI(POST, `/user/auth`); |
Member
Author
There was a problem hiding this comment.
@Dormarble post (/user/auth) 에서 path params이 있는거랑 없는거랑 작동하는 방식이 다른데, api.js에는 하나로만 세팅하고, 프론트에서 API호출 시 setPathParams 세팅 여부에 따라 백에서 분기되는 건가요?
Dormarble
reviewed
Apr 18, 2021
Dormarble
reviewed
Apr 18, 2021
Dormarble
reviewed
Apr 18, 2021
Member
해당 사항 고려하여 API 변경점 재검토 부탁드리겠습니다. |
Member
|
eslint 룰에 어긋나는 부분(quote, arrow-parens 등)이 많은데 확인이 필요합니다. |
Member
|
이메일 입력 없이 코드 전송 요청할 수 있어 보완이 필요해보입니다. |
gunhoflash
approved these changes
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.