Open
Conversation
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Tanish29
reviewed
Nov 29, 2024
Contributor
Author
|
Made changes as asked, ready to merge @Tanish29 |
Contributor
|
thanks for the changes, there are still some files that need to be seen by another person (ideally Zane) since this is a big PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes made from last pull request to include new cone_detection thats implemented in C++
Cone Delete Implementation:
-Deletes cone if it has not been detected for long enough
-has some values that can be optimized based on if they are being used on jetson
Zed_launch launch file, simple launch file that has a description of what parameters it can take in:
only one parameter