Skip to content

feat(frontend): allow continue anyway in unavailable exe path alert dialog #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UNIkeEN merged 1 commit into from
Feb 14, 2026
Merged

feat(frontend): allow continue anyway in unavailable exe path alert dialog #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/modals/unavailable-exe-path-alert-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ const UnavailableExePathAlertDialog: React.FC<
<LuLanguages />
<LanguageMenu placement="top" />
</HStack>
<Button ml="auto" colorScheme="red" onClick={() => exit(0)}>
{t("General.exit")}
</Button>
<HStack ml="auto" spacing={3}>
<Button variant="ghost" onClick={onClose}>
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Continue" button should be assigned the cancelRef to mark it as the least destructive action in the AlertDialog. In Chakra UI AlertDialog, the leastDestructiveRef should point to the button that performs the safer, non-destructive action (continuing) rather than the destructive action (exiting). Add ref={cancelRef} to the Button with variant="ghost" at line 52.

Suggested change
<Button variant="ghost" onClick={onClose}>
<Button ref={cancelRef} variant="ghost" onClick={onClose}>

Copilot uses AI. Check for mistakes.
{t("UnavailableExePathAlertDialog.dialog.btnContinue")}
</Button>
<Button colorScheme="red" onClick={() => exit(0)}>
{t("General.exit")}
</Button>
</HStack>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialogOverlay>
Expand Down
3 changes: 2 additions & 1 deletion src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2561,7 +2561,8 @@
"UnavailableExePathAlertDialog": {
"dialog": {
"title": "Unsafe Execution Path",
"content": "SJMCL is currently running from a temporary or invalid directory. Your settings and game data may be lost. Please move SJMCL to another location and run it again."
"content": "SJMCL is currently running from a temporary or invalid directory. Your settings and game data may be lost. Please move SJMCL to another location and run it again.",
"btnContinue": "Run Anyway"
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translation key "btnContinue" is missing from the Traditional Chinese locale file (zh-Hant.json). All locale files should be updated consistently to ensure the feature works correctly for all supported languages. Add the translation for "Run Anyway" in Traditional Chinese.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translation key "btnContinue" is missing from the French locale file (fr.json). All locale files should be updated consistently to ensure the feature works correctly for all supported languages. Add the translation for "Run Anyway" in French.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new translation key "btnContinue" is missing from the Japanese locale file (ja.json). All locale files should be updated consistently to ensure the feature works correctly for all supported languages. Add the translation for "Run Anyway" in Japanese.

Suggested change
"btnContinue": "Run Anyway"
"btnContinue": "とにかく実行"

Copilot uses AI. Check for mistakes.
}
},
"Utils": {
Expand Down
3 changes: 2 additions & 1 deletion src/locales/zh-Hans.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2561,7 +2561,8 @@
"UnavailableExePathAlertDialog": {
"dialog": {
"title": "无效的运行路径",
"content": "您正在临时或非法目录下运行 SJMCL，您的设置和游戏数据可能丢失。请将 SJMCL 移动到其他位置后再次运行。"
"content": "您正在临时或非法目录下运行 SJMCL，您的设置和游戏数据可能丢失。请将 SJMCL 移动到其他位置后再次运行。",
"btnContinue": "仍要运行"
}
},
"Utils": {
Expand Down
Loading