feat(frontend): make instance and player menu & grid fully clickable#1104
Open
Reqwey wants to merge 2 commits intoUNIkeEN:mainfrom
Open
feat(frontend): make instance and player menu & grid fully clickable#1104Reqwey wants to merge 2 commits intoUNIkeEN:mainfrom
Reqwey wants to merge 2 commits intoUNIkeEN:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the user experience by making instance and player cards fully clickable, even when they contain interactive menu buttons. Previously, cards with menus (withMenu=true) were not clickable zones, forcing users to click only on the radio button or specific areas. Now, users can click anywhere on the card to select it, while menu button clicks are properly isolated using event propagation control.
Key Changes:
- Removed conditional logic that disabled full-click zones when menus were present
- Added
isChildrenIndependentproperty to maintain menu button independence - Implemented
stopPropagation()on all menu interactions to prevent unintended card selection
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/instances-view.tsx | Removed conditional spread operator that disabled isFullClickZone when menu present; added isChildrenIndependent flag |
| src/components/players-view.tsx | Applied same clickability improvements as instances view |
| src/components/instance-menu.tsx | Added stopPropagation() to menu button and all menu items to prevent click bubbling |
| src/components/player-menu.tsx | Added stopPropagation() to menu button and all menu items to prevent click bubbling |
| src/components/common/wrap-card.tsx | Moved click handler from Radio button to parent Card for consistent click behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
This PR is a ..
Related Issues
Description
Additional Context