Skip to content

BUG: Fix populate middleware + Code refactoring - #1

Open
ivan-ivanovv wants to merge 2 commits into
developmentfrom
bug/populate-middleware-refactor
Open

ivan-ivanovv wants to merge 2 commits into
developmentfrom
bug/populate-middleware-refactor

Conversation

@ivan-ivanovv

@ivan-ivanovv ivan-ivanovv commented Feb 5, 2023

Copy link
Copy Markdown
Member

NOTE: Please test this branch with UI before merging as there are query changes

  • Fixed populate middlewares to make requests to User API to make use of caching and minimise requests to PII DB from external services
  • Refactored queries
  • Refactored schemas to remove duplicate schemas and reuse schemas that have the same properties
  • Refactored routes to fix vulnerabilities with deconstructing request payloads
  • Refactored routes to follow best practices for express.js endpoints
  • Refactored controllers
  • Dead code cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant