Skip to content

Conversation

@shervin86
Copy link

No description provided.

@previsualconsent
Copy link
Contributor

Added the DY HT binned samples

@shervin86
Copy link
Author

I have rebased w.r.t. master, a new branch is
transitionTo80X-new

I have isolated some changes that I don't think we want:
3e71b33

If you give me the green light I will revert that commit and replace this PR with one done based on that branch.

The input file for rochester corrections is not hardcoded any more. I've not tried to compile yet.

@jec429
Copy link
Contributor

jec429 commented Oct 24, 2016

Looks good. Will the master branch now correspond to 80X?

@shervin86
Copy link
Author

shervin86 commented Oct 25, 2016 via email

@skalafut
Copy link
Member

The three major changes I see are:

line 271/272 in analysis.cpp - going back to the old version is fine, as
long as it compiles

line 557 in analysis.cpp - Jorge should comment this, but I think we want
to keep this change. ToyThrower() called in analysis.cpp in
transitionTo80X-new will not work without the rochester corrections file
name specified as an input argument.

line 63/64 in configReader.cc - going back to the old version (reading from
Shervin's lxplus eos space) is fine

Regards,
Sean Kalafut

Physics PhD candidate
University of Minnesota Twin Cities

On Mon, Oct 24, 2016 at 7:29 AM, shervin86 [email protected] wrote:

I have rebased w.r.t. master, a new branch is
transitionTo80X-new

I have isolated some changes that I don't think we want:
3e71b33
3e71b33

If you give me the green light I will revert that commit and replace this
PR with one done based on that branch.

The input file for rochester corrections is not hardcoded any more. I've
not tried to compile yet.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#80 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEuaESoCKie25ErwQFrJTyK8BVVSnNwwks5q3KS-gaJpZM4KNrv6
.

@jec429
Copy link
Contributor

jec429 commented Oct 25, 2016

Before we merge this I will replace the electron smearing with the updated recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants