[FEAT #157] nginx 무중단 배포 설정 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DEPLOY] main <- develop 배포
- 주석별로 묶어서 정리했습니다.
ppparkta
approved these changes
Dec 11, 2024
Comment on lines
+6
to
+14
| @RestController | ||
| public class HelloController { | ||
|
|
||
| @GetMapping("/hello") | ||
| public String hello(){ | ||
| return "hello success!"; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
넵 맞습니다!! health_check.sh 배포 스크립트에서 서버 실행하고나서 healthcheck 하는 용으로 사용하려고 만들어뒀습니다!!
There was a problem hiding this comment.
배포 설정 관련해서 궁금한 점이 있습니다. 기존처럼 배포 브랜치로 합병시키면 자동으로 배포되는 것인가요?
네 맞아요!! 기존 배포 파이프라인에서 nginx 무중단 배포 설정만 추가된 거라서 동일하게 main 브랜치로 merge하면 ci/cd가 돌아가게 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
⚙️ ISSUE
💬 To Reviewers
ec2 내부에서 jar 파일로 백그라운드 실행시켰을때는 잘 되는 것 확인했는데, 정확히는 배포해봐야 할 것 같습니다..!!
🔗 Reference
https://velog.io/@hwsa1004/Github-Action-AWS-CodeDeploy-NGINX-%EC%84%9C%EB%B2%84-%EB%AC%B4%EC%A4%91%EB%8B%A8-%EB%B0%B0%ED%8F%AC%ED%95%98%EA%B8%B0