[FIX #116] 일반 회원가입시 ATK, RTK 함께 반환하도록 수정 & JwtAuthenticationFilter 클래스 주석처리 해제 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 인증 필요 없는 API의 경우 필터 통과하지 않도록 shouldNotFilter 메서드 주석 처리 해제
- JwtTokenProvider에서 claim의 subject를 Authentication에서 유저 email 로 수정 - 일반 회원가입 로직 수정
JungYoonShin
changed the title
JungYoonShin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
⚙️ ISSUE
📷 Screenshot
💬 To Reviewers
Authentication을 기반으로 토큰을 생성했었는데, 사용자 email(고유한 값)으로 토큰을 생성하도록 로직을 수정했습니다!
이유는 충분히 사용자 email을 기반으로 고유한 토큰을 만들어 낼 수 있는데 Authentication을 만들면서 리소스를 쓸 필요가 없다 판단하였습니다!
https://github.com/UMC5th-bias/Server/blob/69e9340b9551f4adac1b8660d1456697821f3021/src/main/java/com/favoriteplace/global/security/provider/JwtTokenProvider.java#L32-L51
2. JwtAuthenticationFilter 클래스 shouldNotFilter 주석처리 해제를 해제했습니다! 해당코드가 주석처리가 되어있지 않아야 인증이 필요없는 API의 경우 필터를 통과하지 않게 되는데, 주석처리가 되어있어서 해제하였습니다!
https://github.com/UMC5th-bias/Server/blob/69e9340b9551f4adac1b8660d1456697821f3021/src/main/java/com/favoriteplace/global/security/Filter/JwtAuthenticationFilter.java#L62-L69
🔗 Reference
문제를 해결하면서 도움이 되었거나, 참고했던 사이트(코드링크)