Merged
Conversation
ggamnunq
reviewed
Nov 30, 2025
| import java.util.stream.Collectors; | ||
|
|
||
| @Component | ||
| public class MissionConverter { |
There was a problem hiding this comment.
단순히 값을 변환하는 컨버터에는 빈으로 등록하지 않고 static 메서드로 선언해도 충분해요!
| public List<UserMissionInProgressResponse> getUserInProgress(Long userId, int pageIndex) { | ||
| Pageable pageable = PageRequest.of(pageIndex, 10); | ||
| return converter.toUserMissionList( | ||
| userMissionRepository.findByUserIdAndStatus(userId, MissionStatus.PROCESS, pageable) |
There was a problem hiding this comment.
repository에서 조회하는 부분은 따로 빼서 가독성을 높여줍시다
| @RequestParam Long userId, | ||
| @RequestParam(defaultValue = "1") @ValidPage Integer page | ||
| ) { | ||
| int pageIndex = page - 1; |
| public List<MyReviewResponse> getMyReviews(Long userId, int pageIndex) { | ||
|
|
||
| Pageable pageable = PageRequest.of(pageIndex, 10, Sort.by("createdAt").descending()); | ||
| Page<?> result = reviewRepository.findByUserId(userId, pageable); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.