fix(ui5-side-navigation): add parent item to submenu and enhance ACC #12457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the interaction design, clicking on the parent item in the Overflow menu should only open the sub-menu, but should not select the parent item. Clicking on the parent item in the sub-menu selects it and closes the menu - this is the only way to select the parent item in the overflow menu (the menu lacks two-click area functionality for the moment). This is the reason why we add the parent item again in the sub-menu. List of changes: - new behavior for Space/Enter keys - always trigger action (navigation) and do not expand/collapse - labels for menus in the overflow area - dual click item in overflow: - new aria description for parent item for dual click area - duplicate the parent item as a child item - updated aria-describedby for dual click item in expanded mode JIRA: BGSOFUIRODOPI-3443 JIRA: BGSOFUIRODOPI-3515
LidiyaGeorgieva
requested review from
GerganaKremenska,
Stoev,
TeodorTaushanov,
dimovpetar and
kskondov
|
🚀 Deployed on https://pr-12457--ui5-webcomponents-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the interaction design, clicking on the parent item in the Overflow menu should only open the sub-menu, but should not select the parent item. Clicking on the parent item in the sub-menu selects it and closes the menu - this is the only way to select the parent item in the overflow menu (the menu lacks two-click area functionality for the moment).
This is the reason why we add the parent item again in the sub-menu.
List of changes:
JIRA: BGSOFUIRODOPI-3443
JIRA: BGSOFUIRODOPI-3515