feat(framework): prevent CSS vars from loading #12432
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
requested review from
ilhan007,
pskelin and
vladitasev
and removed request for
ilhan007 and
vladitasev
pskelin
reviewed
Oct 6, 2025
| noConflict: false, // no URL | ||
| formatSettings: {}, | ||
| fetchDefaultLanguage: false, | ||
| fetchDefaultThemingCSSVars: true, |
There was a problem hiding this comment.
lets make the default false like attributes, its easier to read and more logical when people want to set it
There was a problem hiding this comment.
It's left in that way in order to discuss the proper name of the configuration and then it will be renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD: configuration name and default value
Fixes: #12414