Stick to the Lua 5.2 C API #226
Open
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force push to fix CI failures. Same as before, only minimal testing, the actual full automation scripts don't even work with the out of tree patches I have, I'm actually just loading their include files. |
Aegisub requires Luajit implementing Lua 5.2, but the code was making a mixture of Lua 5.1 and Lua 5.2 C API calls which happened to work because luajit's standards compliance is loose. A call to `lua_objlen()` remains because Luajit doesn't implement Lua 5.2 fully and is missing `lua_rawlen()`. Tested with some out of tree patches to make Aegisub work on an unsupported platform (OpenBSD, official Lua).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details.
Some automation scripts don't work (and those aren't pictured), but I believe the cause is the out of tree patching mentioned in the commit, not this PR.