Use parent's font for warning text in preferences #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0tkl
force-pushed
the
0tkl/patch
branch
2 times, most recently
from
2971d80 to
1c13448
Compare
0tkl
changed the title
The original code used wxFONTFAMILY_SWISS to set a bold sans-serif font for the warning message in Preferences/Advanced, assuming that: 1. SWISS always returns a sans-serif font. 2. The system UI font is universally sans-serif across all locales. However, the first assumption is incorrect, and the second one *was* incorrect. On modern Windows under Chinese locales, SWISS will return SimSun or PMingLiU, which are serif fonts with embedded bitmaps that are distributed with legacy Windows as the default interface fonts. The commit fixes the issue by using the parent's font and making it bold instead of directly constructing a wxFont with SWISS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, wxFONTFAMILY_SWISS = a sans-serif font. However when Windows in zh-CN or zh-TW locales, they're displayed in SimSun（宋体）or PMingLIU（細明體）, both are serif and kinda last fallback fonts in their locales. This bug is
clearly attributed to wxWidgetsattributed to the backward compatibility of Windows. We could patch it on wxWidgets' side, but we may need a workaround for a couple of years considering wx's release cycle.This patch can be applied to @arch1t3cht's and @wangqr's fork.