Fixed problem with a mock resolving a mocked value with Promises #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, all symbols except .hasOwnProperty() are stubbed even if they are not assigned a value. This is to be able to track references to all invocations. However, the way that Promise.resolve() works, it checks for the presence of a .then() property and if it is there assumes that the resolve value is a promise so it tries to get its resolved value. But this is a mock reference so the stub does not return a resolved value so the promise never resolves. This fix excludes .then() and .catch() from automatically creating a stub so that Promise will not try to resolve it, but the user can still override the call with a when() clause. This fix also adds "Symbol(Symbol.toPrimitive)" to the exclude list so that by default toString() on a mock will return something other than null.
Added test to verify that adding "Symbol(Symbol.toPrimitive)" to the exclude list will allow toString() conversion to work properly.
In the prior commit, the location of one of the new tests was in the wrong location. This prevented the code from working and the coverage went down. Moved the test to the correct location and everything passes and the coverage went up-- at least on my computer.
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 93.46%
=========================================
Files ? 34
Lines ? 658
Branches ? 82
=========================================
Hits ? 615
Misses ? 30
Partials ? 13 Continue to review full report at Codecov.
|
LironHazan
reviewed
Sep 28, 2021
| }); | ||
|
|
||
| it("does not create then descriptor for interface", () => { | ||
| // given |
There was a problem hiding this comment.
given + when comments are redundant
LironHazan
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR: NagRock#194