[CR-4][P1] Reconstruct PR overview, activity, checks, stack and preview cards #323

Activity

1. BunsDev

   added

   enhancementNew feature or requestNew feature or request

   on Oct 19, 2026
2. BunsDev commented on Oct 20, 2026

   

   BunsDev

   on Oct 20, 2026

   ContributorAuthor

   More actions

   The CR-1 contract is on main as 43d5b9c (#334). Bind to these files at that commit:

   • apps/desktop/src/shared/code-review.ts (the contract)
   • apps/desktop/test/fixtures/code-review.ts (synthetic fixtures)
   • docs/design/code-review.md (source map, references, inventory, open decisions)

   For CR-4:

   • summarizeChecks gives the verdict. Pending is never passing, and only the newest run counts.
   • The R2 and R3 fixtures and the PrOverview, PrActivity and PrStack types are in the contract.
   • The design page proposes two typography tokens for this slice: a ~22 px PR title and a ~24 px prose pitch.

   Coven-Harness: Claude Code / claude-opus-5-5
3. mariscate commented on Oct 22, 2026

   

   mariscate

   on Oct 22, 2026

   More actions

   Refreshed goal prompts — 2026-10-22 (main at 0e674e7)

   Where it stands: not started; this is next in Gate A, alongside #324. Everything it needs is on main:

   • Reads: the overview, activity (cursor), checks (revision) and stack operations in apps/desktop/src/shared/code-review.ts, served by src/main/engine/code-review/read-service.ts.
   • Contract: summarizeChecks, the PrActivity union (commit, opened, comment, review, event, deployment) and PrSummary.stackHint.
   • Fixtures: R1–R3 plus the FAULTS.
   • The host: Integrate Code Review inbox and workspace with main-owned PR reads #367. Its placeholder for this slice is in renderer/code-review/PrPane.tsx.
   • Markdown: full Markdown in replies shipped in v0.3.0. Reuse renderer/components/Markdown.tsx.
   • Avatars (C16/C81): still Val's decision, so show logins only.

   Long-running goal prompt

   Implement CR-4 (#323) in TypeSafeAI/modex. Read AGENTS.md, #319, this issue, docs/design/code-review.md (inventory, typography tokens, open decisions) and the shared contract, then verify main's SHA. Create your own worktree (scripts/worktree.sh new cr4-overview). Replace PrPane's overview placeholder with an overview built on the existing host. Put new components in apps/desktop/src/renderer/code-review/ beside the host, not a new components/code-review folder. Start with red tests against the R1/R2/R3 fixtures and FAULTS: activity pagination with stable ids and no duplicate reviews, partial or failed pages that never show zero, checks verdicts from summarizeChecks (pending is never passing, only the newest run counts, old-head runs marked), stackHint/inferred stacks labelled as inferred, deployment rows with provenance, and hostile Markdown/HTML/URLs left inert. Render text with the existing Markdown component and open links through the existing safe external path. Every write control (comment box, edit, reviewers, state menu) shows as unavailable via capabilities(), owned by #326; the PR question composer belongs to #325. Keep scroll and focus across refresh, and keep the floating composer clear of the last item. Run pnpm build && pnpm test && pnpm test:e2e. Review screenshots of normal, narrow, stale and error states. Record evidence in docs/reviews and update docs/status.md. Open one signed PR and don't merge without Val's go-ahead.
   

   Follow-up / resume prompt

   Resume CR-4. Confirm you own the worktree, fetch main, and read this issue's last checkpoint and your PR's review comments. Re-run the overview/activity e2e and the contract tests before trusting earlier results. If #324 landed meanwhile, merge main and resolve any PrPane conflict while keeping both slices' behaviour. Continue with the next unproven AC: pagination and scroll, honest stale/inferred data, or inert content. Don't change goldens without reviewing them. Post a checkpoint here: SHA, files, commands and results, fixture vs authenticated evidence, and one next action.
   
4. BunsDev

   added a commit that references this issue on Oct 22, 2026

   Add the CR-8 acceptance matrix, Electron journeys and cross-slice reg…

   ...

   ac5fc58
5. BunsDev commented on Oct 23, 2026

   

   BunsDev

   on Oct 23, 2026

   ContributorAuthor

   More actions

   Refreshed goal prompts — 2026-10-23 (main at 203a350)

   On main already:

   • the reads, contract, fixtures and host this slice builds on (CR-1/2/3);
   • the overview placeholder in renderer/code-review/PrPane.tsx.

   The overview itself has not landed.

   In review: #393 (cr4-overview, head 52375d4, base 68860a0; the implementation is in signed commit 485391a).

   What #393 adds:

   • PR metadata and a safe Markdown description;
   • paginated, filterable activity with stable ids;
   • grouped commits;
   • compact checks that use summarizeChecks;
   • reviewers;
   • stacks labelled as inferred, with ambiguous orderings refused;
   • current-head deployment cards read from GitHub's deployment/status endpoints;
   • unavailable write controls, with callback slots left for CR-7.

   Evidence (2026-10-23-cr4-overview.md):

   • pnpm build && pnpm test: 2,020 passed, 16 skipped. One earlier rerun failed six terminal-cleanup cases; they pass on their own, and the cause is not identified.
   • pnpm test:e2e: 400 desktop passed, 7 skipped.
   • The overview spec passed 9 of 9.
   • An authenticated read-only service smoke ran against Define the Code Review read contract and fixtures (CR-1) #334.
   • CI is green and the PR merges cleanly.

   Still open:

   • an independent review of feat(code-review): add PR overview, activity and evidence cards #393 on GitHub, and Val's go-ahead to merge;
   • the R1/R2 comparison against the originals, which are missing from the manifest's paths;
   • authenticated rendering in Electron, which wasn't exercised;
   • live account switching;
   • human VoiceOver;
   • avatars (C16/C81), which are still Val's decision, so the overview shows logins only.

   CR-5's unpushed cr5-remote-diffs branch also changes PrPane.tsx, CodeReviewView.tsx and code-review.css. Whichever lands second merges main.

   Long-running goal prompt

   Land CR-4 (#323) in TypeSafeAI/modex. The implementation is PR #393 (branch cr4-overview); do not start over.
   
   Read AGENTS.md, #319, this issue, docs/design/code-review.md and #393's evidence doc (docs/reviews/2026-10-23-cr4-overview.md), then verify main's SHA. Work in the cr4-overview worktree only if you own it; otherwise claim it with scripts/worktree.sh claim, or ask its owner.
   
   1. Get an independent review of #393 and fix important findings with red tests first: activity pagination and refresh, stale and inferred data never shown as fresh or empty, inert hostile Markdown, HTML and URLs, unavailable write controls through capabilities(), and focus/scroll across refresh.
   2. If CR-5 lands first, merge main and reconcile PrPane, CodeReviewView and code-review.css so that both slices' behaviour holds.
   3. With Val's go-ahead, run an authenticated Electron render of the overview, separate from the service smoke.
   4. Hand CR-8 (#327) the head SHA so it can add the R2 journey step.
   
   Run pnpm build && pnpm test && pnpm test:e2e. Investigate the terminal-cleanup failures if they recur. Update the evidence doc and docs/status.md. Use signed commits, and don't merge without Val's go-ahead.
   

   Follow-up / resume prompt

   Resume CR-4.
   1. Confirm you own cr4-overview, fetch main, and read #393's review comments and this issue's last checkpoint.
   2. Re-run e2e/code-review-overview.spec.ts and the contract tests on the current head.
   3. If main moved (CR-5 or anything touching PrPane), merge it and re-run the full suite.
   4. Fix the next open review finding, or the weakest AC.
   Don't change goldens without reviewing them. Post a checkpoint here: SHA, commands and results, fixture vs authenticated evidence, what waits on Val, and one next action.
   
6. BunsDev

   self-assigned this

   on Oct 28, 2026
7. BunsDev

   added a commit that references this issue on Nov 3, 2026

   test(code-review): measure composer clearance beside the inline Ask s…

   ...

   78ecc56