Move text changes handling from react component to the wrapper #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
force-pushed
the
fix-text-changes-callback
branch
from
6fad370 to
0ec4c88
Compare
kaisalmen
force-pushed
the
fix-text-changes-callback
branch
from
0ec4c88 to
5f391fa
Compare
|
@CGNonofr this is now ready for review. I added a unit test. |
|
@CGNonofr thank you. So I guess you agree/confirm that lesser logic in react is a plus. |
Sure! I don't want code to be duplicated between framework implementations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bad design choice that is corrected. The react component should be thinnest possible layer around the wrapper.