Skip to content

Commit

Permalink
Update verification examples: Remove duplicates, dependency updates a…
Browse files Browse the repository at this point in the history
…nd global volta node version update
  • Loading branch information
kaisalmen committed Feb 12, 2025
1 parent 8f87e0d commit ea57ad8
Show file tree
Hide file tree
Showing 41 changed files with 13,067 additions and 15,361 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2",
"pnpm": "9.15.4",
"pnpm": "10.3.0",
"yarn": "4.6.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/resources/debugger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"npm": ">=10.9.2"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-ws-jsonrpc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/wrapper-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/wrapper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"dependencies": {
Expand Down
2,800 changes: 1,525 additions & 1,275 deletions verify/angular/package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions verify/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"npm": ">=10.2.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
},
"dependencies": {
Expand All @@ -26,8 +26,8 @@
"@angular-builders/custom-esbuild": "~18.0.0",
"@angular/cli": "~18.2.8",
"@angular/compiler-cli": "~18.2.8",
"@codingame/esbuild-import-meta-url-plugin": "~1.0.2",
"@types/node": "~22.10.5",
"@codingame/esbuild-import-meta-url-plugin": "~1.0.3",
"@types/node": "~22.13.1",
"css-loader": "~7.1.2",
"shx": "~0.3.4",
"style-loader": "~4.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,20 @@ export class MonacoAngularWrapperComponent implements OnDestroy {
const textModels = this.wrapper.getTextModels();
if (textModels?.modified !== undefined && wrapperConfig !== undefined) {
const newSubscriptions: monaco.IDisposable[] = [];
this.emitCodeChange(textModels, wrapperConfig);
this.emitCodeChange(textModels);
newSubscriptions.push(
textModels.modified.onDidChangeContent(() => {
this.emitCodeChange(textModels, wrapperConfig);
this.emitCodeChange(textModels);
})
);
}
}

emitCodeChange(textModels: TextModels, wrapperConfig: WrapperConfig) {
emitCodeChange(textModels: TextModels) {
const onTextChanged = (textChanges: TextContents) => {
this.onTextChanged.emit(textChanges.modified);
};
didModelContentChange(textModels, wrapperConfig.editorAppConfig?.codeResources, onTextChanged);
didModelContentChange(textModels, onTextChanged);
}

}
3 changes: 0 additions & 3 deletions verify/buildAll.ps1
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
$MyPath = Split-Path -Path $MyInvocation.MyCommand.Path -Parent

# yarn first, because it usually has the most problems
Set-Location $MyPath/yarn; npm run verify:ci
Set-Location $MyPath/vite; npm run verify:ci
Set-Location $MyPath/webpack; npm run verify:ci
Set-Location $MyPath/angular; npm run verify:ci
Set-Location $MyPath/next; npm run verify:ci
Set-Location $MyPath/pnpm; pnpm run verify:ci

Set-Location $MyPath
3 changes: 0 additions & 3 deletions verify/buildAll.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
MyPath=$(realpath $(dirname $0))

# yarn first, because it usually has the most problems
cd $MyPath/yarn; npm run verify:ci
cd $MyPath/vite; npm run verify:ci
cd $MyPath/webpack; npm run verify:ci
cd $MyPath/angular; npm run verify:ci
cd $MyPath/next; npm run verify:ci
cd $MyPath/pnpm; pnpm run verify:ci

cd $MyPath
3 changes: 2 additions & 1 deletion verify/buildPeers.ps1
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
$MyPath = Split-Path -Path $MyInvocation.MyCommand.Path -Parent

# yarn first, because it usually has the most problems
Set-Location $MyPath/peerYarn; npm run verify:ci
Set-Location $MyPath/peerNpm; npm run verify:ci
Set-Location $MyPath/peerPnpm; pnpm run verify:ci
Set-Location $MyPath/peerYarn; npm run verify:ci

Set-Location $MyPath
3 changes: 2 additions & 1 deletion verify/buildPeers.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
MyPath=$(realpath $(dirname $0))

# yarn first, because it usually has the most problems
cd $MyPath/peerYarn; npm run verify:ci
cd $MyPath/peerNpm; npm run verify:ci
cd $MyPath/peerPnpm; pnpm run verify:ci
cd $MyPath/peerYarn; npm run verify:ci

cd $MyPath
2,870 changes: 1,560 additions & 1,310 deletions verify/next/package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions verify/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@
"dependencies": {
"@typefox/monaco-editor-react": "~6.3.0",
"monaco-languageclient-examples": "~2025.2.5",
"next": "~15.1.6",
"next": "~15.1.7",
"react": "~19.0.0",
"react-dom": "~19.0.0"
},
"devDependencies": {
"@types/node": "~22.12.0",
"@types/node": "~22.13.1",
"@types/react": "~19.0.8",
"@types/react-dom": "~19.0.3",
"shx": "~0.3.4",
"typescript": "~5.7.3"
},
"volta": {
"node": "22.13.1",
"node": "22.14.0",
"npm": "10.9.2"
}
}
Loading

0 comments on commit ea57ad8

Please sign in to comment.