Skip to content

fix: prevent errors when accessing DOM during editor unmount #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent errors when accessing DOM during editor unmount #2190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/react/src/components/FormattingToolbar/DefaultButtons/CreateLinkButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,23 @@ export const CreateLinkButton = () => {
return;
}

editor.prosemirrorView.dom.addEventListener("keydown", callback);
// Capture the DOM element at the time the effect runs. Guard against
// cases where the editor view is not available (e.g. during unmount).
const dom = editor.prosemirrorView?.dom;
if (!dom) {
return;
}

dom.addEventListener("keydown", callback);

return () => {
editor.prosemirrorView.dom.removeEventListener("keydown", callback);
// Use the captured `dom` reference for cleanup. If the editor view
// was torn down, this avoids accessing `editor.prosemirrorView.dom`.
if (dom && dom.removeEventListener) {
dom.removeEventListener("keydown", callback);
}
};
}, [editor.prosemirrorView, editor.headless]);
}, [editor.headless, editor.prosemirrorView]);

const update = useCallback(
(url: string) => {
Expand Down