Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom schema for React comment editors #1545

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

milanpoliak
Copy link

Making it possible to pass custom schemas to comments.

Related issue: #1543

Copy link

vercel bot commented Mar 18, 2025

@milanpoliak is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@milanpoliak milanpoliak changed the title Commets/custom schema Support custom schema for React comment editors Mar 18, 2025
@YousefED
Copy link
Collaborator

YousefED commented Mar 19, 2025

Awesome, thanks for creating this PR. Does this solve all your requirements? I figured it might be also be useful to allow all options of the editors to be easily customized? e.g. allow consumers to implement a function getBlockNoteEditorOptions("comment-composer") that returns the options for (in this case) the composer

PS: what are you building?

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 19, 2025 6:58am

@milanpoliak
Copy link
Author

Awesome, thanks for creating this PR. Does this solve all your requirements? I figured it might be also be useful to allow all options of the editors to be easily customized? e.g. allow consumers to implement a function getBlockNoteEditorOptions("comment-composer") that returns the options for (in this case) the composer

Yeah, it solves all I need right now, but the idea of a function to provide all other options sounds really good. I won't have time to implement it today, but I can take a stab at it in the next few days.

PS: what are you building?

We are migrating our news site from WordPress to a custom CMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants