feat: split out localization files for optimized bundle #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ```txt vite v5.3.4 building for production... ✓ 168 modules transformed. dist/webpack-stats.json 14.00 kB │ gzip: 2.39 kB dist/style.css 11.63 kB │ gzip: 2.82 kB dist/comments.js 17.39 kB │ gzip: 3.51 kB │ map: 49.43 kB dist/blocknote.js 416.35 kB │ gzip: 93.27 kB │ map: 1,103.85 kB dist/webpack-stats.json 14.01 kB │ gzip: 2.41 kB dist/style.css 11.63 kB │ gzip: 2.82 kB dist/comments.cjs 11.72 kB │ gzip: 2.85 kB │ map: 47.30 kB dist/blocknote.cjs 273.46 kB │ gzip: 72.57 kB │ map: 1,044.26 kB ✓ built in 506ms ``` After: ```txt vite v5.3.4 building for production... ✓ 170 modules transformed. dist/webpack-stats.json 14.50 kB │ gzip: 2.52 kB dist/style.css 11.63 kB │ gzip: 2.82 kB dist/en-BEb_5vQO.js 7.78 kB │ gzip: 1.91 kB │ map: 14.03 kB dist/comments.js 17.39 kB │ gzip: 3.51 kB │ map: 49.43 kB dist/locales.js 135.64 kB │ gzip: 27.15 kB │ map: 238.90 kB dist/blocknote.js 274.20 kB │ gzip: 65.23 kB │ map: 853.96 kB dist/webpack-stats.json 14.51 kB │ gzip: 2.52 kB dist/style.css 11.63 kB │ gzip: 2.82 kB dist/en-DoDAHwFo.cjs 5.34 kB │ gzip: 1.76 kB │ map: 12.34 kB dist/comments.cjs 11.72 kB │ gzip: 2.85 kB │ map: 47.30 kB dist/locales.cjs 93.50 kB │ gzip: 24.76 kB │ map: 210.56 kB dist/blocknote.cjs 175.52 kB │ gzip: 47.01 kB │ map: 823.91 kB ✓ built in 588ms ``` Shaved ~100kb from cjs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Mar 17, 2025
I'd have to test, but I think they should be tree-shaked based on access. So not sure if we need to be that granular. But, I can quickly test this |
good point! if it's tree-shaken then it's fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is a breaking change, since I had to change the export, but an easy one to make
Before:
After:
Shaved ~100kb from cjs