Use CMake and support clients using CMake#5
Merged
Conversation
Contributor
Author
|
Oops, sticky shift key. |
Owner
|
leave WIN32_LEAN_AND_MEAN in the file and I'll add it (reasoning: cmake should be completely optional) |
_CRT_SECURE_NO_WARNINGS still has to be left in the build system, because the localtime function is declared via <string>, which comes from the header, but it is a Windows specific definition that should not be present in the header file.
Contributor
Author
|
Would also be worth seeing where #4 goes. I could just rebase and adapt changes from that instead of having to do 2 PRs. |
Owner
|
sure, cmake is entirely irrelevant to me so if you wanna wait till mac/linux support is in to add it then let me know. im not gonna maintain cmakelists.txt myself, someone will have to update it when new platforms are added |
Contributor
Author
|
Seems the other PR went dormant. You could accept this then I can review CMake related changes in the other PR if it ever gets picked back up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3 and some compiler warnings. Moved
WIN32_LEAN_AND_MEANto the build system.I have also seen someone wanting to add Linux support, which should be easy by just extending the
if().For anyone wanting to add tests to this, you'll just have to add these lines at the end:
Lines 12-16 make it possible for users to consume this project like so:
Vendoring via
add_subdirectory(or anything that wraps it) is NOT supported. That would require even more code for no good reason.