Skip to content

revert badge rarity calculation to go back to when gen2 was added #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

revert badge rarity calculation to go back to when gen2 was added #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion TPP.Persistence.MongoDB/Repos/BadgeRepo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ public class BadgeRepo(
public readonly IMongoCollection<Badge> Collection = database.GetCollection<Badge>(CollectionName);
public readonly IMongoCollection<BadgeStat> CollectionStats = database.GetCollection<BadgeStat>(CollectionNameStats);

private static readonly Instant WhenGen2WasAddedToPinball = Instant.FromUtc(2018, 3, 28, 12, 00);
/// Instant at which some update was deployed that is expected to majorly disrupt badge rarities,
/// e.g. if a whole new generation was added to pinball.
private static readonly Instant LastRarityUpdate = WhenGen2WasAddedToPinball;

/// Pinball drops enough badges that a somewhat small time-span is already statistically significant.
/// Also, if Pinball ever gets tweaked and natural drop chances change, ignoring old badges gradually
/// transitions to the new rarities.
Expand Down Expand Up @@ -248,7 +253,7 @@ public async Task RenewBadgeStats(IImmutableSet<PkmnSpecies>? onlyTheseSpecies =
{
var stopwatch = Stopwatch.StartNew();
Instant now = clock.GetCurrentInstant();
Instant startTime = now - _rarityCalculationTransition;
Instant startTime = Instant.Min(LastRarityUpdate, now - _rarityCalculationTransition);

IAggregateFluent<Badge> pipeline = Collection.Aggregate(new AggregateOptions { AllowDiskUse = true });
if (onlyTheseSpecies != null)
Expand Down