Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› 메인 λ ˆμ΄μ•„μ›ƒ 및 판맀 νŽ˜μ΄μ§€ νƒ­ λ„€λΉ„κ²Œμ΄μ…˜ 였λ₯˜ μˆ˜μ • #15

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

changhwan77
Copy link
Collaborator

@changhwan77 changhwan77 commented Feb 29, 2024

Title

πŸ› 메인 λ ˆμ΄μ•„μ›ƒ 및 판맀 νŽ˜μ΄μ§€ νƒ­ λ„€λΉ„κ²Œμ΄μ…˜ 였λ₯˜ μˆ˜μ •

What type of PR is this?

  • πŸ• Feature ( μƒˆλ‘œμš΄ κΈ°λŠ₯ μΆ”κ°€ )
  • πŸ› Bug Fix ( 버그 μˆ˜μ • )
  • πŸ“ Documentation Update ( 개발자 κ΄€λ ¨ λ¬Έμ„œ μ—…λ°μ΄νŠΈ )
  • 🎨 Style ( μ½”λ“œ ν¬λ§·νŒ…, μ„Έλ―Έμ½œλ‘  λˆ„λ½, μ½”λ“œ 변경이 μ—†λŠ” 경우 )
  • πŸ§‘β€πŸ’» Code Refactor ( μ½”λ“œ λ¦¬νŽ™ν† λ§ )
  • πŸ”₯ Performance Improvements ( μ„±λŠ₯ ν–₯상 )
  • βœ… Test ( ν…ŒμŠ€νŠΈ μ½”λ“œ, λ¦¬νŽ™ν† λ§ ν…ŒμŠ€νŠΈ μ½”λ“œ μΆ”κ°€ )
  • πŸ€– Build ( λΉŒλ“œ )
  • πŸ” CI
  • πŸ“¦ Chore (Release) (λΉŒλ“œ 업무 μˆ˜μ •, νŒ¨ν‚€μ§€ λ§€λ‹ˆμ € μˆ˜μ • )
  • ⏩ Revert ( 컀밋을 λ‚ λ¦° 경우 )

Description

2μ°¨ 배포λ₯Ό μœ„ν•΄

  • 메인 λ ˆμ΄μ•„μ›ƒ 버그
  • 메인 λ°°λ„ˆ 클릭 μ‹œ 판맀 νƒ­ 이동 λ„€λΉ„κ²Œμ΄μ…˜ 버그
  • 토큰이 없을 μ‹œ μŠ€λ‚΅λ°”μ™€ tuti νƒ­μœΌλ‘œ μ΄λ™ν•˜κ²Œ ν•˜λŠ” 둜직 제거
  • λ°°λ„ˆ 클릭 μ‹œ λ©”μ„œλ“œ μˆ˜μ •

Related Issue number and link

  • Jira :
  • Issue :

Mobile & Desktop Screenshots/Recordings

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

To Reviewers

}
// if (context.mounted) {
// context.go('/tuti');
// }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카였 둜그인 심사λ₯Ό μœ„ν•΄ λΉ„λ‘œκ·ΈμΈ μœ μ €κ°€ 접속 μ‹œ μŠ€λ‚΅λ°” + tuti νƒ­μœΌλ‘œ μ΄λ™ν•˜λŠ” 둜직 제거

],
return ConstraintsScaffold(
child: Container(
margin: EdgeInsets.symmetric(horizontal: 20.w),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νŠΈν‹° νƒ­ ν™”λ©΄ λ ˆμ΄μ•„μ›ƒ 쑰정을 μœ„ν•΄ λ§ˆμ§„ μΆ”κ°€.

즉, ConstranitsScaffold μ—μ„œ Container의 widthλ₯Ό 700으둜 μ œν•œν•˜κ³  있기 λ•Œλ¬Έμ— 이 λΆ€λΆ„μ—μ„œ λ ˆμ΄μ•„μ›ƒμ„ μ‘°μ •ν•΄μ•Ό νŠΈν‹° νƒ­μ˜ λ ˆμ΄μ•„μ›ƒμ΄ 쑰정됨.

final String title;
final String subtitle;

@override
Widget build(BuildContext context) {
Widget build(BuildContext context, WidgetRef ref) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ°°λ„ˆ 클릭 μ‹œ λ„€λΉ„κ²Œμ΄μ…˜ 둜직이 ν†΅μΌλ˜μ§€ μΌ€μ΄μŠ€ λ³„λ‘œ λ‹€λ₯΄λ―€λ‘œ onTapλ©”μ„œλ“œλ₯Ό μƒμœ„μ—μ„œ μ „λ‹¬ν•˜λ„λ‘ μ„€μ •.

background: TuTiBanner(
onTap: () {
// νŒλ§€νŽ˜μ΄μ§€ νƒ­μœΌλ‘œ 이동
ref.read(navigationSelectedIndexProvider.notifier).state = 0;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νŒλ§€νŽ˜μ΄μ§€ νƒ­μœΌλ‘œ μ΄λ™ν•˜λŠ” 둜직 μΆ”κ°€

@changhwan77 changhwan77 merged commit f876df8 into Tuti-Project:feature Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant